maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

- 45b4111d940009bc7b3ebf621c9cb9293c60344a Use copied value i in lambda by Abseil Team <absl-team@google.com>

Browse source 
- b726b3102f8439b8480b6ff52fc3660162fa0bd9 Fix MSVC compiler warning on 32-bit platforms (GitHub iss... by Derek Mauro <dmauro@google.com>
  - a8a29e636c85bd7d82c0cbc824a1c2e498764337 Explicitly forbid to specify the template parameter to Wr... by Abseil Team <absl-team@google.com>
  - 566a1d903266fdbfdcf758401c356a0c6703422d Add missing license header to BUILD file. by Alex Strelnikov <strel@google.com>
  - ef1c0642cde0bbad62bbb30715256b232a4ab817 Fix BUILD file header. by Alex Strelnikov <strel@google.com>
  - b6e2cf00f808ee32b9eb7b3226af79d628742c20 Release GraphCycles microbenchmark. by Alex Strelnikov <strel@google.com>
  - f592d78f549e7a242bf2bb4858a26645a655eac3 Release Mutex microbenchmarks. by Alex Strelnikov <strel@google.com>

GitOrigin-RevId: 45b4111d940009bc7b3ebf621c9cb9293c60344a
Change-Id: I82885ae176952a764574c6d4616e312a977407b2
This commit is contained in:
Abseil Team 2018-05-22 16:34:47 -07:00 • committed by katzdm
parent 3e671c7821
commit 014f02a3ec
11 changed files with 255 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

28
absl/synchronization/internal/graphcycles.cc
View file

@ -37,6 +37,7 @@
#include <algorithm>
#include <array>
#include "absl/base/internal/hide_ptr.h"
#include "absl/base/internal/raw_logging.h"
#include "absl/base/internal/spinlock.h"
@ -276,18 +277,6 @@ inline uint32_t NodeVersion(GraphId id) {
return static_cast<uint32_t>(id.handle >> 32);
}
// We need to hide Mutexes (or other deadlock detection's pointers)
// from the leak detector. Xor with an arbitrary number with high bits set.
static const uintptr_t kHideMask = static_cast<uintptr_t>(0xF03A5F7BF03A5F7Bll);
static inline uintptr_t MaskPtr(void *ptr) {
return reinterpret_cast<uintptr_t>(ptr) ^ kHideMask;
}
static inline void* UnmaskPtr(uintptr_t word) {
return reinterpret_cast<void*>(word ^ kHideMask);
}
struct Node {
int32_t rank; // rank number assigned by Pearce-Kelly algorithm
uint32_t version; // Current version number
@ -309,7 +298,7 @@ class PointerMap {
}
int32_t Find(void* ptr) {
auto masked = MaskPtr(ptr);
auto masked = base_internal::HidePtr(ptr);
for (int32_t i = table_[Hash(ptr)]; i != -1;) {
Node* n = (*nodes_)[i];
if (n->masked_ptr == masked) return i;
@ -327,7 +316,7 @@ class PointerMap {
int32_t Remove(void* ptr) {
// Advance through linked list while keeping track of the
// predecessor slot that points to the current entry.
auto masked = MaskPtr(ptr);
auto masked = base_internal::HidePtr(ptr);
for (int32_t* slot = &table_[Hash(ptr)]; *slot != -1; ) {
int32_t index = *slot;
Node* n = (*nodes_)[index];
@ -395,7 +384,7 @@ bool GraphCycles::CheckInvariants() const {
NodeSet ranks; // Set of ranks seen so far.
for (uint32_t x = 0; x < r->nodes_.size(); x++) {
Node* nx = r->nodes_[x];
void* ptr = UnmaskPtr(nx->masked_ptr);
void* ptr = base_internal::UnhidePtr<void>(nx->masked_ptr);
if (ptr != nullptr && static_cast<uint32_t>(r->ptrmap_.Find(ptr)) != x) {
ABSL_RAW_LOG(FATAL, "Did not find live node in hash table %u %p", x, ptr);
}
@ -427,7 +416,7 @@ GraphId GraphCycles::GetId(void* ptr) {
n->version = 1; // Avoid 0 since it is used by InvalidGraphId()
n->visited = false;
n->rank = rep_->nodes_.size();
n->masked_ptr = MaskPtr(ptr);
n->masked_ptr = base_internal::HidePtr(ptr);
n->nstack = 0;
n->priority = 0;
rep_->nodes_.push_back(n);
@ -439,7 +428,7 @@ GraphId GraphCycles::GetId(void* ptr) {
int32_t r = rep_->free_nodes_.back();
rep_->free_nodes_.pop_back();
Node* n = rep_->nodes_[r];
n->masked_ptr = MaskPtr(ptr);
n->masked_ptr = base_internal::HidePtr(ptr);
n->nstack = 0;
n->priority = 0;
rep_->ptrmap_.Add(ptr, r);
@ -461,7 +450,7 @@ void GraphCycles::RemoveNode(void* ptr) {
}
x->in.clear();
x->out.clear();
x->masked_ptr = MaskPtr(nullptr);
x->masked_ptr = base_internal::HidePtr<void>(nullptr);
if (x->version == std::numeric_limits<uint32_t>::max()) {
// Cannot use x any more
} else {
@ -472,7 +461,8 @@ void GraphCycles::RemoveNode(void* ptr) {
void* GraphCycles::Ptr(GraphId id) {
Node* n = FindNode(rep_, id);
return n == nullptr ? nullptr : UnmaskPtr(n->masked_ptr);
return n == nullptr ? nullptr
: base_internal::UnhidePtr<void>(n->masked_ptr);
}
bool GraphCycles::HasNode(GraphId node) {

46
absl/synchronization/internal/graphcycles_benchmark.cc Normal file
View file

@ -0,0 +1,46 @@
// Copyright 2018 The Abseil Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "absl/synchronization/internal/graphcycles.h"
#include <algorithm>
#include <cstdint>
#include <vector>
#include "benchmark/benchmark.h"
#include "absl/base/internal/raw_logging.h"
namespace {
void BM_StressTest(benchmark::State& state) {
const int num_nodes = state.range(0);
while (state.KeepRunningBatch(num_nodes)) {
absl::synchronization_internal::GraphCycles g;
std::vector<absl::synchronization_internal::GraphId> nodes(num_nodes);
for (int i = 0; i < num_nodes; i++) {
nodes[i] = g.GetId(reinterpret_cast<void*>(static_cast<uintptr_t>(i)));
}
for (int i = 0; i < num_nodes; i++) {
int end = std::min(num_nodes, i + 5);
for (int j = i + 1; j < end; j++) {
ABSL_RAW_CHECK(g.InsertEdge(nodes[i], nodes[j]), "");
}
}
}
}
BENCHMARK(BM_StressTest)->Range(2048, 1048576);
} // namespace
BENCHMARK_MAIN();