maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

The expr of AttrNames/DynamicAttrDefs is always an ExprConcatStrings

Browse source
This commit is contained in:
Shea Levy 2014-03-09 14:41:02 -04:00 • committed by Eelco Dolstra
parent 908e9ce259
commit 049a379ec6
3 changed files with 10 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/libexpr/eval.cc
View file

@ -642,15 +642,13 @@ void ExprAttrs::eval(EvalState & state, Env & env, Value & v)
/* dynamic attrs apply *after* rec and __overrides */
foreach (DynamicAttrDefs::iterator, i, dynamicAttrs) {
Value nameVal;
assert(dynamic_cast<ExprConcatStrings *>(i->nameExpr));
ExprConcatStrings * nameExpr = static_cast<ExprConcatStrings *>(i->nameExpr);
if (nameExpr->es->size() == 1) {
nameExpr->es->front()->eval(state, *dynamicEnv, nameVal);
if (i->nameExpr->es->size() == 1) {
i->nameExpr->es->front()->eval(state, *dynamicEnv, nameVal);
state.forceValue(nameVal);
if (nameVal.type == tNull)
continue;
}
nameExpr->eval(state, *dynamicEnv, nameVal);
i->nameExpr->eval(state, *dynamicEnv, nameVal);
state.forceStringNoCtx(nameVal);
Symbol nameSym = state.symbols.create(nameVal.string.s);
Bindings::iterator j = v.attrs->find(nameSym);

10
src/libexpr/nixexpr.hh
View file

@ -50,16 +50,16 @@ struct Env;
struct Value;
class EvalState;
struct StaticEnv;
struct Expr;
struct ExprConcatStrings;
/* An attribute path is a sequence of attribute names. */
struct AttrName
{
Symbol symbol;
Expr *expr;
ExprConcatStrings * expr;
AttrName(const Symbol & s) : symbol(s) {};
AttrName(Expr *e) : expr(e) {};
AttrName(ExprConcatStrings * e) : expr(e) {};
};
typedef std::vector<AttrName> AttrPath;
@ -174,10 +174,10 @@ struct ExprAttrs : Expr
typedef std::map<Symbol, AttrDef> AttrDefs;
AttrDefs attrs;
struct DynamicAttrDef {
Expr * nameExpr;
ExprConcatStrings * nameExpr;
Expr * valueExpr;
Pos pos;
DynamicAttrDef(Expr * nameExpr, Expr * valueExpr, const Pos & pos) : nameExpr(nameExpr), valueExpr(valueExpr), pos(pos) { };
DynamicAttrDef(ExprConcatStrings * nameExpr, Expr * valueExpr, const Pos & pos) : nameExpr(nameExpr), valueExpr(valueExpr), pos(pos) { };
};
typedef std::vector<DynamicAttrDef> DynamicAttrDefs;
DynamicAttrDefs dynamicAttrs;

4
src/libexpr/parser.y
View file

@ -488,7 +488,7 @@ attrpath
$$->push_back(AttrName(str->s));
delete str;
} else
$$->push_back(AttrName($3));
$$->push_back(AttrName(static_cast<ExprConcatStrings *>($3)));
}
| attr { $$ = new vector<AttrName>; $$->push_back(AttrName(data->symbols.create($1))); }
| string_attr
@ -498,7 +498,7 @@ attrpath
$$->push_back(AttrName(str->s));
delete str;
} else
$$->push_back(AttrName($1));
$$->push_back(AttrName(static_cast<ExprConcatStrings *>($1)));
}
;