maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libexpr: Don't create lots of temporary strings in Bindings::lexicographicOrder

Browse source 
Avoids ~180,000 string temporaries created when evaluating a headless
NixOS system.
This commit is contained in:
Tuomas Tynkkynen 2018-02-19 22:47:25 +02:00
parent d4e93532e2
commit 056d28a601
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/libexpr/attr-set.hh
View file

@ -83,7 +83,7 @@ public:
for (size_t n = 0; n < size_; n++) for (size_t n = 0; n < size_; n++)
res.emplace_back(&attrs[n]); res.emplace_back(&attrs[n]);
std::sort(res.begin(), res.end(), [](const Attr * a, const Attr * b) { std::sort(res.begin(), res.end(), [](const Attr * a, const Attr * b) {
return (string) a->name < (string) b->name; return (const string &) a->name < (const string &) b->name;
}); });
return res; return res;
} }