maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(tvix/eval): implement attrset update (//) operator

Browse source 
The underlying implementation does a few tricks based on which pair of
attrset representations is encountered.

Particularly the effect of short-circuiting the empty cases might be
relevant in nixpkgs/NixOS, due to the use of lib.optionalAttrs.

Change-Id: I22b978b1c69af12926489a71087c6a6219c012f3
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6140
Reviewed-by: sterni <sternenseemann@systemli.org>
Tested-by: BuildkiteCI
This commit is contained in:
Vincent Ambo 2022-08-10 21:01:15 +03:00 • committed by tazjin
parent fa2d250d1a
commit 058e77bab2
13 changed files with 87 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
tvix/eval/src/tests/tvix_tests/eval-okay-attrs-update-empty-lhs.exp Normal file
View file

@ -0,0 +1 @@
{ a = "ok"; }

1
tvix/eval/src/tests/tvix_tests/eval-okay-attrs-update-empty-lhs.nix Normal file
View file

@ -0,0 +1 @@
{} // { a = "ok"; }

1
tvix/eval/src/tests/tvix_tests/eval-okay-attrs-update-empty-rhs.exp Normal file
View file

@ -0,0 +1 @@
{ a = "ok"; }

1
tvix/eval/src/tests/tvix_tests/eval-okay-attrs-update-empty-rhs.nix Normal file
View file

@ -0,0 +1 @@
{ a = "ok"; } // {}

1
tvix/eval/src/tests/tvix_tests/eval-okay-attrs-update-kv-lhs.exp Normal file
View file

@ -0,0 +1 @@
{ name = "foo"; other = 42; value = "bar"; }

1
tvix/eval/src/tests/tvix_tests/eval-okay-attrs-update-kv-lhs.nix Normal file
View file

@ -0,0 +1 @@
{ name = "foo"; value = "bar"; } // { other = 42; }

1
tvix/eval/src/tests/tvix_tests/eval-okay-attrs-update.exp Normal file
View file

@ -0,0 +1 @@
{ a = 15; b = "works"; }

1
tvix/eval/src/tests/tvix_tests/eval-okay-attrs-update.nix Normal file
View file

@ -0,0 +1 @@
{ a = 15; } // { b = "works"; }