maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(tvix/eval): simplify let ... in ... before recursion

Browse source 
While full recursion through thunking is not available, there are
actually incorrect behaviours introduced by declaring before
binding (example in the newly introduced test).

This commit simplifies the implementation to avoid this issue, and
also because I intend to explore a bit more how far we can get in non
left-to-right bindings *without* introducing thunks immediately.

Change-Id: I21fd3007ac3946570639772d7d624d70bd209958
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6226
Tested-by: BuildkiteCI
Reviewed-by: sterni <sternenseemann@systemli.org>
Reviewed-by: grfn <grfn@gws.fyi>
This commit is contained in:
Vincent Ambo 2022-08-16 14:40:06 +03:00 • committed by tazjin
parent 75ba7c0120
commit 0b51d63081
3 changed files with 14 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

1
tvix/eval/src/tests/tvix_tests/eval-okay-nested-let.exp Normal file
View file

@ -0,0 +1 @@
7

7
tvix/eval/src/tests/tvix_tests/eval-okay-nested-let.nix Normal file
View file

@ -0,0 +1,7 @@
let
a = let
b = 1;
c = 2;
in b + c;
b = 4;
in a + b