maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(3p/nix): Fix all remaining compiler warnings

Browse source 
This compiles under `-Wall -Werror`.

The largest chunk of this change is `final` qualifiers for the various
Nix CLI command structs, which inherit from a Command class that has
more virtual functions than are implemented by each command.

Change-Id: I0925e6e1a39013f026773db5816e4a77d50f3b4a
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1294
Tested-by: BuildkiteCI
Reviewed-by: isomer <isomer@tvl.fyi>
Reviewed-by: kanepyork <rikingcoding@gmail.com>
This commit is contained in:
Vincent Ambo 2020-07-19 21:52:35 +01:00 • committed by tazjin
parent ca50fb66d2
commit 15afa8472e
33 changed files with 66 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

7
third_party/nix/src/libstore/nar-info-disk-cache.cc vendored
View file

@ -49,7 +49,7 @@ create table if not exists LastPurge (
)sql";
class NarInfoDiskCacheImpl : public NarInfoDiskCache {
class NarInfoDiskCacheImpl final : public NarInfoDiskCache {
public:
/* How often to purge expired entries from the cache. */
const int purgeInterval = 24 * 3600;
@ -280,8 +280,9 @@ class NarInfoDiskCacheImpl : public NarInfoDiskCache {
}
};
ref<NarInfoDiskCache> getNarInfoDiskCache() {
static ref<NarInfoDiskCache> cache = make_ref<NarInfoDiskCacheImpl>();
std::shared_ptr<NarInfoDiskCache> getNarInfoDiskCache() {
static std::shared_ptr<NarInfoDiskCache> cache =
std::make_shared<NarInfoDiskCacheImpl>();
return cache;
}