maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(tvix): add CI targets for checking crate features powerset

Browse source 
Closes: https://b.tvl.fyi/issues/401

With this change all crate features (and their combinations) will be built and
tested in CI.

From now on, when adding/removing a Cargo feature for a crate,
you will want to add it to the features power set that gets tested in CI.
For each crate there's a default.nix with a `mkFeaturePowerset` invocation,
modify the list to include/remove the feature.
Note that you don't want to add "collection" features,
such as `fs` for tvix-[ca]store or `default`.

Change-Id: I966dde1413d057770787da3296cce9c1924570e0
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11717
Reviewed-by: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
This commit is contained in:
Ilan Joselevich 2024-05-26 17:27:10 +03:00
parent c93849a3fc
commit 1b39d5868a
10 changed files with 112 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

44
tvix/store/default.nix
View file

@ -1,4 +1,4 @@
{ depot, pkgs, ... }:
{ depot, pkgs, lib, ... }:
let
mkImportCheck = p: expectedPath: {
@ -22,31 +22,35 @@ let
};
in
(depot.tvix.crates.workspaceMembers.tvix-store.build.override {
(depot.tvix.crates.workspaceMembers.tvix-store.build.override (old: {
runTests = true;
testPreRun = ''
export SSL_CERT_FILE=${pkgs.cacert}/etc/ssl/certs/ca-bundle.crt
'';
# enable some optional features.
features = [ "default" "cloud" ]
# virtiofs feature currently fails to build on Darwin.
++ pkgs.lib.optional pkgs.stdenv.isLinux "virtiofs";
}).overrideAttrs (_: {
meta.ci.targets = [ "integration-tests" ];
meta.ci.extraSteps = {
import-docs = (mkImportCheck "tvix/store/docs" ./docs);
features = old.features
# virtiofs feature currently fails to build on Darwin
++ lib.optional pkgs.stdenv.isLinux "virtiofs";
})).overrideAttrs (old: rec {
meta.ci = {
targets = [ "integration-tests" ] ++ lib.filter (x: lib.hasPrefix "with-features" x || x == "no-features") (lib.attrNames passthru);
extraSteps.import-docs = (mkImportCheck "tvix/store/docs" ./docs);
};
passthru.integration-tests = depot.tvix.crates.workspaceMembers.tvix-store.build.override {
runTests = true;
testPreRun = ''
passthru = (depot.tvix.utils.mkFeaturePowerset {
inherit (old) crateName;
features = ([ "cloud" "fuse" "otlp" "tonic-reflection" ]
# virtiofs feature currently fails to build on Darwin
++ lib.optional pkgs.stdenv.isLinux "virtiofs");
override.testPreRun = ''
export SSL_CERT_FILE=${pkgs.cacert}/etc/ssl/certs/ca-bundle.crt
export PATH="$PATH:${pkgs.lib.makeBinPath [pkgs.cbtemulator pkgs.google-cloud-bigtable-tool]}"
'';
# enable some optional features.
features = [ "default" "cloud" "integration" ]
# virtiofs feature currently fails to build on Darwin.
++ pkgs.lib.optional pkgs.stdenv.isLinux "virtiofs";
}) // {
integration-tests = depot.tvix.crates.workspaceMembers.${old.crateName}.build.override (old: {
runTests = true;
testPreRun = ''
export SSL_CERT_FILE=${pkgs.cacert}/etc/ssl/certs/ca-bundle.crt;
export PATH="$PATH:${pkgs.lib.makeBinPath [ pkgs.cbtemulator pkgs.google-cloud-bigtable-tool ]}"
'';
features = old.features ++ [ "integration" ];
});
};
})