feat(tvix/store): use reqwests' rustls-native-roots feature

This makes reqwest honor `SSL_CERT_FILE` - previously it was using the
chain bundled in webpki-roots.

`object_store` pulls in `reqwest` with this feature, and the cargo
solver will enable that feature globally as soon as we pull it in, as it
assumes features are additive.

This requires setting `SSL_CERT_FILE` when running tests, otherwise
they'll fail with the unhelpful "NotFound" error.

This was quite some fun to debug, why adding `object_store` to
tvix-castore suddenly made tvix-store tests fail!

Change-Id: I64fc82b4d994715480efdb1ffecb279716456ab9
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11090
Reviewed-by: raitobezarius <tvl@lahfa.xyz>
Tested-by: BuildkiteCI
This commit is contained in:
Florian Klink 2024-03-03 16:47:32 +02:00 committed by flokli
parent 4b4443240e
commit 1c16dee207
4 changed files with 14 additions and 23 deletions

View file

@ -24,6 +24,10 @@ in
(depot.tvix.crates.workspaceMembers.tvix-store.build.override {
runTests = true;
testPreRun = ''
export SSL_CERT_FILE=${pkgs.cacert}/etc/ssl/certs/ca-bundle.crt;
'';
# virtiofs feature currently fails to build on Darwin.
# we however can ship it for non-darwin.
features = if pkgs.stdenv.isDarwin then [ "default" ] else [ "default" "virtiofs" ];