maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(3p/lisp/mime4cl): make MIME-BODY-STREAM always return characters

Browse source 
Because OPEN-DECODED-FILE-PORTION only knows about transfer encodings it
would only return a character stream for 7bit encoded bodies. This
causes inconsistent behavior where some bodies would return binary and
some character streams. To fix this, we specialize MIME-BODY-STREAM for
MIME-TEXT parts which may or may not be a good enough solution.

We may actually want to make MIME-BODY-STREAM binary always and let the
user handle decoding?! This may be a good idea to take care after yet
another stream machinery redesign.

Since the mime4cl test suite doesn't test MIME-BODY-STREAM (much), add a
message generated by notemap that hits this issue to the mblog golden
test suite.

Change-Id: Ie340c42ced6c693af9b3c84b177408d6b6d2c9c4
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12913
Reviewed-by: sterni <sternenseemann@systemli.org>
Autosubmit: sterni <sternenseemann@systemli.org>
Tested-by: BuildkiteCI
This commit is contained in:
sterni 2024-12-26 00:22:31 +01:00 • committed by clbot
parent 0ead86ec89
commit 1f5e1383f5
7 changed files with 42 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
users/sterni/mblog/golden/default.nix
View file

@ -6,8 +6,11 @@ let
maildir = pkgs.runCommandNoCC "mblog-golden-example-maildir" { } ''
mkdir -p "$out/cur"
cp --reflink=auto \
"${depot.path.origSrc + "/third_party/lisp/mime4cl/test/samples/mail-note.msg"}" \
"${depot.path.origSrc + "/third_party/lisp/mime4cl/test/samples/mail-note-from-notes-app.msg"}" \
"$out/cur/1732277542.274467_1.wolfgang,U=1:2,S"
cp --reflink=auto \
"${depot.path.origSrc + "/third_party/lisp/mime4cl/test/samples/mail-note-from-notemap.msg"}" \
"$out/cur/1735167350.823243_1.wolfgang,U=32:2,S"
'';
# Make golden test based on the given mblog derivation and add subtarget

4
users/sterni/mblog/golden/expected/d2ccdc74-830c-41ee-9d64-2221f1c35449/index.html Normal file
View file

@ -0,0 +1,4 @@
<!DOCTYPE html>
<html><head><meta charset='utf-8'><meta viewport='width=device-width'><title>test.txt</title><link rel='stylesheet' type='text/css' href='../style.css'></head><body><header><nav><a href='..'>index</a></nav></header><main><article>grüße from notemap
</article></main></body></html>

2
users/sterni/mblog/golden/expected/index.html
View file

@ -1,2 +1,2 @@
<!DOCTYPE html>
<html><head><meta charset='utf-8'><meta viewport='width=device-width'><title>mblog</title><link rel='stylesheet' type='text/css' href='style.css'></head><body><header><nav><a href=''>index</a></nav></header><main><h1>mblog</h1><table><tr><td><a href='d81cb91d-c210-46b1-835a-6a7c34db666b'>example note</a></td><td>2024-11-22T11&#183;49+00</td></tr></table></main></body></html>
<html><head><meta charset='utf-8'><meta viewport='width=device-width'><title>mblog</title><link rel='stylesheet' type='text/css' href='style.css'></head><body><header><nav><a href=''>index</a></nav></header><main><h1>mblog</h1><table><tr><td><a href='d2ccdc74-830c-41ee-9d64-2221f1c35449'>test.txt</a></td><td>2024-12-25T22&#183;54+00</td></tr><tr><td><a href='d81cb91d-c210-46b1-835a-6a7c34db666b'>example note</a></td><td>2024-11-22T11&#183;49+00</td></tr></table></main></body></html>