maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tvix/eval): consider let ... inherit ... in dynamic scopes

Browse source 
In conditions where no dynamic identifiers exist in a scope,
inheriting is usually a no-op - *unless* the identifier is not
statically known and the scope has a non-empty `with`-stack.

Change-Id: Iff4138d9cd4c56e844bc574203708dacc11c3f73
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6264
Reviewed-by: sterni <sternenseemann@systemli.org>
Tested-by: BuildkiteCI
This commit is contained in:
Vincent Ambo 2022-08-24 20:01:39 +03:00 • committed by tazjin
parent c3b13416b0
commit 2023b8e33f
3 changed files with 40 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
tvix/eval/src/tests/tvix_tests/eval-okay-useless-inherit-with.exp Normal file
View file

@ -0,0 +1 @@
1

15
tvix/eval/src/tests/tvix_tests/eval-okay-useless-inherit-with.nix Normal file
View file

@ -0,0 +1,15 @@
# Normally using an `inherit` without a source attribute set within a
# `let` is a no-op, *unless* there is a with in-scope that might
# provide the value.
# Provide a dynamic `x` identifier in the scope.
with ({ x = 1;});
# inherit this `x` as a static identifier
let inherit x;
# Provide another dynamic `x` identifier
in with ({ x = 3; });
# Inherited static identifier should have precedence
x