maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(external): Skip folders with "no buildable Go files"

Browse source 
This error is returned by the build analysis logic if the target
package does not have any relevant Go files, which might be the case
if `+build` flags and such are used.
This commit is contained in:
Vincent Ambo 2019-12-12 23:53:39 +00:00 • committed by Vincent Ambo
parent 39e73f42b2
commit 218b81c709
1 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

15
external/main.go vendored
View file

@ -43,14 +43,15 @@ func findGoDirs(at string) ([]string, error) {
dirSet := make(map[string]bool) dirSet := make(map[string]bool)
err := filepath.Walk(at, func(path string, info os.FileInfo, err error) error { err := filepath.Walk(at, func(path string, info os.FileInfo, err error) error {
name := info.Name()
// Skip folders that are guaranteed to not be relevant // Skip folders that are guaranteed to not be relevant
if info.IsDir() && (info.Name() == "testdata" || info.Name() == ".git") { if info.IsDir() && (name == "testdata" || name == ".git") {
return filepath.SkipDir return filepath.SkipDir
} }
// If the current file is a Go file, then the directory is popped // If the current file is a Go file, then the directory is popped
// (i.e. marked as a Go directory). // (i.e. marked as a Go directory).
if !info.IsDir() && strings.HasSuffix(info.Name(), ".go") && !strings.HasSuffix(info.Name(), "_test.go") { if !info.IsDir() && strings.HasSuffix(name, ".go") && !strings.HasSuffix(name, "_test.go") {
dirSet[filepath.Dir(path)] = true dirSet[filepath.Dir(path)] = true
} }
@ -154,6 +155,16 @@ func main() {
all := []pkg{} all := []pkg{}
for _, d := range goDirs { for _, d := range goDirs {
analysed, err := analysePackage(*source, d, *path, stdlibPkgs) analysed, err := analysePackage(*source, d, *path, stdlibPkgs)
// If the Go source analysis returned "no buildable Go files",
// that directory should be skipped.
//
// This might be due to `+build` flags on the platform and other
// reasons (such as test files).
if _, ok := err.(*build.NoGoError); ok {
continue
}
if err != nil { if err != nil {
log.Fatalf("failed to analyse package at %q: %s", d, err) log.Fatalf("failed to analyse package at %q: %s", d, err)
} }