maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve example AbslUnparseFlag().

Browse source 
1. Move default case outside switch.  This is a good practice because it allows -Wswitch to warn about missing enum values.

2. Use absl::StrCat() instead of (nonexistent) SimpleItoa().
This commit is contained in:
Michael Shields 2019-06-20 11:54:01 -07:00 • committed by GitHub
parent 43ef2148c0
commit 23dc759538
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
absl/flags/marshalling.h
View file

@ -106,10 +106,10 @@
// // Returns a textual flag value corresponding to the OutputMode `mode`. // // Returns a textual flag value corresponding to the OutputMode `mode`.
// std::string AbslUnparseFlag(OutputMode mode) { // std::string AbslUnparseFlag(OutputMode mode) {
// switch (mode) { // switch (mode) {
// case kPlainText: return "plaintext"; // case kPlainText: return "plaintext";
// case kHtml: return "html"; // case kHtml: return "html";
// default: return SimpleItoa(mode);
// } // }
// return absl::SimpleItoa(mode);
// } // }
// //
// Notice that neither `AbslParseFlag()` nor `AbslUnparseFlag()` are class // Notice that neither `AbslParseFlag()` nor `AbslUnparseFlag()` are class