gerrit: Use a Gerrit label instead of hashtag for autosubmit
This moves to using a Gerrit label ('Autosubmit') with boolean values
for determining whether a developer wants to have a change
automatically submitted.
See also https://cl.tvl.fyi/c/depot/+/4172
This commit is contained in:
parent
c67b3ba7ea
commit
24f5a642af
5 changed files with 17 additions and 44 deletions
|
|
@ -26,7 +26,6 @@ type IClient interface {
|
|||
GetChangesetURL(changeset *Changeset) string
|
||||
SubmitChangeset(changeset *Changeset) (*Changeset, error)
|
||||
RebaseChangeset(changeset *Changeset, ref string) (*Changeset, error)
|
||||
RemoveTag(changeset *Changeset, tag string) (*Changeset, error)
|
||||
ChangesetIsRebasedOnHEAD(changeset *Changeset) bool
|
||||
SerieIsRebasedOnHEAD(serie *Serie) bool
|
||||
FilterSeries(filter func(s *Serie) bool) []*Serie
|
||||
|
|
@ -161,21 +160,6 @@ func (c *Client) RebaseChangeset(changeset *Changeset, ref string) (*Changeset,
|
|||
return c.fetchChangeset(changeInfo.ChangeID)
|
||||
}
|
||||
|
||||
// RemoveTag removes the submit queue tag from a changeset and updates gerrit
|
||||
// we never add, that's something users should do in the GUI.
|
||||
func (c *Client) RemoveTag(changeset *Changeset, tag string) (*Changeset, error) {
|
||||
hashTags := changeset.HashTags
|
||||
newHashTags := []string{}
|
||||
for _, hashTag := range hashTags {
|
||||
if hashTag != tag {
|
||||
newHashTags = append(newHashTags, hashTag)
|
||||
}
|
||||
}
|
||||
// TODO: implement setting hashtags api in go-gerrit and use here
|
||||
// https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#set-hashtags
|
||||
return changeset, nil
|
||||
}
|
||||
|
||||
// GetBaseURL returns the gerrit base URL
|
||||
func (c *Client) GetBaseURL() string {
|
||||
return c.baseURL
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue