[CMake] Set correct flags for clang-cl (#278)
clang-cl produce binaries with MSVC ABI and wants to be as flag-compatible with pure MSVC as possible, so this leads to all sorts of weird cases. clang-cl alias /Wall as clang's -Weverything which is way too verbose, so it needs /W3 like pure MSVC. clang-cl only understand GCC style warning flags (-W[no]blah) and just silent drop MSVC style warning flags (/wd[num]). clang-cl needs MSVC define flags since it is consuming the same header files as pure MSVC. CMake set CMAKE_CXX_COMPILER_ID as Clang when clang-cl is detected, so need extra if (MSVC) to differentiate it. We are not doing clang-cl specialization in Bazel as currently there is no reliable way to detect clang-cl in Bazel.. This PR should be NFC for LLVM/GCC users on Unix platforms. Other changes: Add ABSL_ prefix to variable names to avoid name collision in CMake.
This commit is contained in:
parent
e75672f6af
commit
253eb74164
6 changed files with 346 additions and 169 deletions
2
.gitignore
vendored
2
.gitignore
vendored
|
|
@ -11,5 +11,5 @@ CMakeLists.txt.user
|
|||
# Ignore VS Code files
|
||||
.vscode/*
|
||||
# Ignore generated python artifacts
|
||||
copts/copts.pyc
|
||||
*.pyc
|
||||
copts/__pycache__/
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue