maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(tvix/eval): Validate closed formals

Browse source 
Validate "closed formals" (formal parameters without an ellipsis) via a
new ValidateClosedFormals op, which checks the arguments (in an attr set
at the top of the stack) against the formal parameters on the Lambda in
the current frame, and returns a new UnexpectedArgument error (including
the span of the formals themselves!!) if any arguments aren't allowed

Change-Id: Idcc47a59167a83be1832a6229f137d84e426c56c
Reviewed-on: https://cl.tvl.fyi/c/depot/+/7002
Reviewed-by: tazjin <tazjin@tvl.su>
Tested-by: BuildkiteCI
This commit is contained in:
Griffin Smith 2022-10-12 23:53:03 -04:00 • committed by tazjin
parent e63d14419f
commit 2a3d498104
7 changed files with 133 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

13
tvix/eval/src/compiler/mod.rs
View file

@ -787,6 +787,11 @@ impl Compiler<'_> {
self.scope_mut().mark_initialised(set_idx);
self.emit_force(pattern);
let ellipsis = pattern.ellipsis_token().is_some();
if !ellipsis {
self.push_op(OpCode::OpValidateClosedFormals, pattern);
}
// Similar to `let ... in ...`, we now do multiple passes over
// the bindings to first declare them, then populate them, and
// then finalise any necessary recursion into the scope.
@ -837,16 +842,10 @@ impl Compiler<'_> {
}
}
// TODO: strictly check if all keys have been consumed if
// there is no ellipsis.
let ellipsis = pattern.ellipsis_token().is_some();
if !ellipsis {
self.emit_warning(pattern, WarningKind::NotImplemented("closed formals"));
}
Formals {
arguments,
ellipsis,
span,
}
}