feat(tvix/eval): Implement builtins.sort

Browse source

This is a bit tricky because the comparator can throw errors, so we
need to propagate them out if they exist and try to avoid sorting
forever by returning a reasonable ordering in this case (as
short-circuiting is not available).

Co-Authored-By: Vincent Ambo <tazjin@tvl.su>
Change-Id: Icae1d30f43ec1ae64b2ba51e73ee467605686792
Reviewed-on: https://cl.tvl.fyi/c/depot/+/7072
Tested-by: BuildkiteCI
Reviewed-by: sterni <sternenseemann@systemli.org>

...

This commit is contained in:

Griffin Smith 2022-10-23 13:50:07 -04:00 • committed by tazjin

parent d0a836b0e1

commit 3412ae4956

4 changed files with 46 additions and 3 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

0

tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-sort.exp → tvix/eval/src/tests/nix_tests/eval-okay-sort.exp

Unescape Escape View file

0

tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-sort.nix → tvix/eval/src/tests/nix_tests/eval-okay-sort.nix

Unescape Escape View file