maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(tazjin/rlox): Implement comparison operators

Browse source 
Change-Id: I03b751db52a3bd502fb4fbda6e89cad087ccad74
Reviewed-on: https://cl.tvl.fyi/c/depot/+/2575
Reviewed-by: tazjin <mail@tazj.in>
Tested-by: BuildkiteCI
This commit is contained in:
Vincent Ambo 2021-02-28 16:00:01 +02:00 • committed by tazjin
parent c58fe2093e
commit 369f504250
4 changed files with 43 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

28
users/tazjin/rlox/src/bytecode/compiler.rs
View file

@ -128,6 +128,22 @@ fn rule_for<T: Iterator<Item = Token>>(token: &TokenKind) -> ParseRule<T> {
ParseRule::new(None, Some(Compiler::binary), Precedence::Equality)
}
TokenKind::Greater => {
ParseRule::new(None, Some(Compiler::binary), Precedence::Comparison)
}
TokenKind::GreaterEqual => {
ParseRule::new(None, Some(Compiler::binary), Precedence::Comparison)
}
TokenKind::Less => {
ParseRule::new(None, Some(Compiler::binary), Precedence::Comparison)
}
TokenKind::LessEqual => {
ParseRule::new(None, Some(Compiler::binary), Precedence::Comparison)
}
_ => ParseRule::new(None, None, Precedence::None),
}
}
@ -209,6 +225,18 @@ impl<T: Iterator<Item = Token>> Compiler<T> {
}
TokenKind::EqualEqual => self.emit_op(OpCode::OpEqual),
TokenKind::Greater => self.emit_op(OpCode::OpGreater),
TokenKind::GreaterEqual => {
self.emit_op(OpCode::OpLess);
self.emit_op(OpCode::OpNot);
}
TokenKind::Less => self.emit_op(OpCode::OpLess),
TokenKind::LessEqual => {
self.emit_op(OpCode::OpGreater);
self.emit_op(OpCode::OpNot);
}
_ => unreachable!("only called for binary operator tokens"),
}