maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(tvix/store): rename import::{import_path -> ingest_path}

Browse source 
This distinguishes it better from the EvalIO::import_path method.
Also update the docstring to explain what it does (and what it doesn't).

Change-Id: I32a8b2869fa67a894df28532b22bf170961a2abf
Reviewed-on: https://cl.tvl.fyi/c/depot/+/8578
Reviewed-by: tazjin <tazjin@tvl.su>
Autosubmit: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
This commit is contained in:
Florian Klink 2023-05-17 14:21:26 +03:00 • committed by clbot
parent a6c7869393
commit 3a4e29c261
3 changed files with 13 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

13
tvix/store/src/import.rs
View file

@ -136,14 +136,15 @@ fn process_entry<BS: BlobService, DP: DirectoryPutter>(
todo!("handle other types")
}
/// Imports the contents at a given Path into the tvix store.
/// Ingests the contents at the given path into the tvix store,
/// interacting with a [BlobService] and [DirectoryService].
/// It returns the root node or an error.
///
/// It doesn't register the contents at a Path in the store itself, that's up
/// to the PathInfoService.
//
// returns the root node, or an error.
/// It's not interacting with a [PathInfoService], it's up to the caller to
/// possibly register it somewhere (and potentially rename it based on some
/// naming scheme.
#[instrument(skip(blob_service, directory_service), fields(path=?p))]
pub fn import_path<BS: BlobService, DS: DirectoryService, P: AsRef<Path> + Debug>(
pub fn ingest_path<BS: BlobService, DS: DirectoryService, P: AsRef<Path> + Debug>(
blob_service: &mut BS,
directory_service: &mut DS,
p: P,