fix(gerrit): return HTML titles in more cases

At present, we don't return HTML titles if there's a trailing slash,
or a patchset. Instead, just consume the / and anything after it.

This also fixes /123, because this is HTTP redirected to the full path
*with a trailing slash* which otherwise wouldn't get the title
injected.

Change-Id: Idfd0e67752880a37dce0b400a3c1cfc53fac2912
Reviewed-on: https://cl.tvl.fyi/c/depot/+/859
Reviewed-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
Tested-by: BuildkiteCI
This commit is contained in:
Luke Granger-Brown 2020-07-02 23:28:39 +01:00 committed by lukegb
parent 26bb34823d
commit 3f6518ce99
5 changed files with 64 additions and 11 deletions

View file

@ -1,13 +0,0 @@
diff --git a/tools/js/download_bower.py b/tools/js/download_bower.py
index 1df4b826bc..65bda74082 100755
--- a/tools/js/download_bower.py
+++ b/tools/js/download_bower.py
@@ -106,7 +106,7 @@ def main():
args.b, '--quiet', 'install', '%s#%s' % (args.p, args.v)))
bc = os.path.join(cwd, 'bower_components')
subprocess.check_call(
- ['zip', '-q', '--exclude', '.bower.json', '-r', cached, args.n],
+ ['detzip', '--exclude', '.bower.json', cached, args.n],
cwd=bc)
if args.s: