refactor(3p/nix): Apply clang-tidy's performance-* fixes

This applies the performance fixes listed here:

https://clang.llvm.org/extra/clang-tidy/checks/list.html
This commit is contained in:
Vincent Ambo 2020-05-20 22:58:43 +01:00
parent 689ef502f5
commit 43677021e3
60 changed files with 189 additions and 166 deletions

View file

@ -18,7 +18,8 @@ class Exit : public std::exception {
virtual ~Exit();
};
int handleExceptions(const string& programName, std::function<void()> fun);
int handleExceptions(const string& programName,
const std::function<void()>& fun);
/* Don't forget to call initPlugins() after settings are initialized! */
void initNix();
@ -40,9 +41,9 @@ void printGCWarning();
class Store;
void printMissing(ref<Store> store, const PathSet& paths);
void printMissing(const ref<Store>& store, const PathSet& paths);
void printMissing(ref<Store> store, const PathSet& willBuild,
void printMissing(const ref<Store>& store, const PathSet& willBuild,
const PathSet& willSubstitute, const PathSet& unknown,
unsigned long long downloadSize, unsigned long long narSize);