refactor(3p/nix): Apply clang-tidy's performance-* fixes

This applies the performance fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html
2020-05-20 22:58:43 +01:00 · 2020-05-20 22:58:43 +01:00 · 43677021e3
commit 43677021e3
parent 689ef502f5
60 changed files with 189 additions and 166 deletions
--- a/third_party/nix/src/libstore/export-import.cc
+++ b/third_party/nix/src/libstore/export-import.cc
@ -55,7 +55,8 @@ void Store::exportPath(const Path& path, Sink& sink) {
                   << 0;
 }

-Paths Store::importPaths(Source& source, std::shared_ptr<FSAccessor> accessor,
+Paths Store::importPaths(Source& source,
+                         const std::shared_ptr<FSAccessor>& accessor,
                         CheckSigsFlag checkSigs) {
  Paths res;
  while (true) {