refactor(3p/nix): Apply clang-tidy's performance-* fixes

This applies the performance fixes listed here:

https://clang.llvm.org/extra/clang-tidy/checks/list.html
This commit is contained in:
Vincent Ambo 2020-05-20 22:58:43 +01:00
parent 689ef502f5
commit 43677021e3
60 changed files with 189 additions and 166 deletions

View file

@ -246,7 +246,7 @@ pid_t startProcess(std::function<void()> fun,
/* Run a program and return its stdout in a string (i.e., like the
shell backtick operator). */
string runProgram(Path program, bool searchPath = false,
string runProgram(const Path& program, bool searchPath = false,
const Strings& args = Strings(),
const std::optional<std::string>& input = {});
@ -453,7 +453,7 @@ struct InterruptCallback {
/* Register a function that gets called on SIGINT (in a non-signal
context). */
std::unique_ptr<InterruptCallback> createInterruptCallback(
std::function<void()> callback);
const std::function<void()>& callback);
void triggerInterrupt();