maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(3p/nix): Apply clang-tidy's performance-* fixes

Browse source 
This applies the performance fixes listed here:

https://clang.llvm.org/extra/clang-tidy/checks/list.html
This commit is contained in:
Vincent Ambo 2020-05-20 22:58:43 +01:00
parent 689ef502f5
commit 43677021e3
60 changed files with 189 additions and 166 deletions
Download patch file Download diff file Expand all files Collapse all files

6
third_party/nix/src/nix-daemon/nix-daemon.cc vendored
View file

@ -194,9 +194,9 @@ struct RetrieveRegularNARSink : ParseSink {
}
};
static void performOp(TunnelLogger* logger, ref<Store> store, bool trusted,
unsigned int clientVersion, Source& from, Sink& to,
unsigned int op) {
static void performOp(TunnelLogger* logger, const ref<Store>& store,
bool trusted, unsigned int clientVersion, Source& from,
Sink& to, unsigned int op) {
switch (op) {
case wopIsValidPath: {
/* 'readStorePath' could raise an error leading to the connection