maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(3p/nix): Apply clang-tidy's performance-* fixes

Browse source 
This applies the performance fixes listed here:

https://clang.llvm.org/extra/clang-tidy/checks/list.html
This commit is contained in:
Vincent Ambo 2020-05-20 22:58:43 +01:00
parent 689ef502f5
commit 43677021e3
60 changed files with 189 additions and 166 deletions
Download patch file Download diff file Expand all files Collapse all files

2
third_party/nix/src/nix-store/dotgraph.cc vendored
View file

@ -79,7 +79,7 @@ void printClosure(const Path & nePath, const StoreExpr & fs)
}
#endif
void printDotGraph(ref<Store> store, const PathSet& roots) {
void printDotGraph(const ref<Store>& store, const PathSet& roots) {
PathSet workList(roots);
PathSet doneSet;

2
third_party/nix/src/nix-store/dotgraph.hh vendored
View file

@ -6,6 +6,6 @@ namespace nix {
class Store;
void printDotGraph(ref<Store> store, const PathSet& roots);
void printDotGraph(const ref<Store>& store, const PathSet& roots);
} // namespace nix

2
third_party/nix/src/nix-store/graphml.cc vendored
View file

@ -37,7 +37,7 @@ static string makeNode(const ValidPathInfo& info) {
(isDerivation(info.path) ? "derivation" : "output-path"));
}
void printGraphML(ref<Store> store, const PathSet& roots) {
void printGraphML(const ref<Store>& store, const PathSet& roots) {
PathSet workList(roots);
PathSet doneSet;
std::pair<PathSet::iterator, bool> ret;

2
third_party/nix/src/nix-store/graphml.hh vendored
View file

@ -6,6 +6,6 @@ namespace nix {
class Store;
void printGraphML(ref<Store> store, const PathSet& roots);
void printGraphML(const ref<Store>& store, const PathSet& roots);
} // namespace nix

3
third_party/nix/src/nix-store/nix-store.cc vendored
View file

@ -28,6 +28,9 @@ using namespace nix;
using std::cin;
using std::cout;
// TODO(tazjin): clang-tidy's performance lints don't like this, but
// the automatic fixes fail (it seems that some of the ops want to own
// the args for whatever reason)
using Operation = void (*)(Strings, Strings);
static Path gcRoot;