maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(tvix/eval): box PathBuf

Browse source 
This shaves another 8 bytes off Value. How did that type get so big?!

Change-Id: I65e9b59a1636bd57e3cc4aec5fea16887070b832
Reviewed-on: https://cl.tvl.fyi/c/depot/+/8153
Reviewed-by: raitobezarius <tvl@lahfa.xyz>
Tested-by: BuildkiteCI
This commit is contained in:
Vincent Ambo 2023-02-27 13:50:16 +03:00 • committed by tazjin
parent 52b7a76268
commit 43d04d9b98
5 changed files with 16 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tvix/eval/src/compiler/mod.rs
View file

@ -342,7 +342,10 @@ impl Compiler<'_> {
debug_assert!(raw_path.len() > 2 && raw_path.starts_with("~/"));
let home_relative_path = &raw_path[2..(raw_path.len())];
c.emit_constant(Value::UnresolvedPath(home_relative_path.into()), node);
c.emit_constant(
Value::UnresolvedPath(Box::new(home_relative_path.into())),
node,
);
c.push_op(OpCode::OpResolveHomePath, node);
});
} else if raw_path.starts_with('<') {
@ -356,7 +359,7 @@ impl Compiler<'_> {
let path = &raw_path[1..(raw_path.len() - 1)];
// Make a thunk to resolve the path (without using `findFile`, at least for now?)
return self.thunk(slot, node, move |c, _| {
c.emit_constant(Value::UnresolvedPath(path.into()), node);
c.emit_constant(Value::UnresolvedPath(Box::new(path.into())), node);
c.push_op(OpCode::OpFindFile, node);
});
} else {
@ -367,7 +370,7 @@ impl Compiler<'_> {
// TODO: Use https://github.com/rust-lang/rfcs/issues/2208
// once it is available
let value = Value::Path(crate::value::canon_path(path));
let value = Value::Path(Box::new(crate::value::canon_path(path)));
self.emit_constant(value, node);
}