maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

S3BinaryCacheStore:: Eliminate a string copy while uploading

Browse source 
This cuts hydra-queue-runner's peak memory usage by about a third.
This commit is contained in:
Eelco Dolstra 2016-11-16 16:21:30 +01:00
parent 10ae8fabf1
commit 4be4f6de56
No known key found for this signature in database
GPG key ID: 8170B4726D7198DE
4 changed files with 17 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/libstore/derivations.cc
View file

@ -155,7 +155,7 @@ static StringSet parseStrings(std::istream & str, bool arePaths)
static Derivation parseDerivation(const string & s)
{
Derivation drv;
std::istringstream str(s);
istringstream_nocopy str(s);
expect(str, "Derive([");
/* Parse the list of outputs. */

2
src/libstore/s3-binary-cache-store.cc
View file

@ -145,7 +145,7 @@ struct S3BinaryCacheStoreImpl : public S3BinaryCacheStore
.WithBucket(bucketName)
.WithKey(path);
auto stream = std::make_shared<std::stringstream>(data);
auto stream = std::make_shared<istringstream_nocopy>(data);
request.SetBody(stream);