maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore(tvix/store): Use BoxStream type alias

Browse source 
The BoxStream type alias is a more concise and easier to read than
the full `Pin<Box<dyn Stream<Item = ...> + Send + ...>>` type.

Change-Id: I5b7bccfd066ded5557e01f7895f4cf5c4a33bd44
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10677
Reviewed-by: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
Autosubmit: Connor Brewster <cbrewster@hey.com>
This commit is contained in:
Connor Brewster 2024-01-20 16:25:39 -06:00 • committed by clbot
parent 56ba7a72d8
commit 4e341fb5d9
15 changed files with 44 additions and 67 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tvix/castore/src/proto/grpc_blobservice_wrapper.rs
View file

@ -1,11 +1,10 @@
use crate::blobservice::BlobService;
use core::pin::pin;
use futures::TryFutureExt;
use futures::{stream::BoxStream, TryFutureExt};
use std::{
collections::VecDeque,
io,
ops::{Deref, DerefMut},
pin::Pin,
};
use tokio_stream::StreamExt;
use tokio_util::io::ReaderStream;
@ -86,8 +85,7 @@ where
T: Deref<Target = dyn BlobService> + Send + Sync + 'static,
{
// https://github.com/tokio-rs/tokio/issues/2723#issuecomment-1534723933
type ReadStream =
Pin<Box<dyn futures::Stream<Item = Result<super::BlobChunk, Status>> + Send + 'static>>;
type ReadStream = BoxStream<'static, Result<super::BlobChunk, Status>>;
#[instrument(skip(self))]
async fn stat(