feat(tvix/eval): add generator "name" to NativeError kind
This produces traces in which we can see what kind of native code was run. Note that these "names" are named after the generator message, so these aren't *really* intended for end-user consumption, but we can give them saner names later. Example: https://gist.github.com/tazjin/82b24e92ace8e821008954867ee05057 This already makes the traces a little easier to parse. Change-Id: Idcd601baf84f492211b732ea0f04b377112e10d0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/8268 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su>
This commit is contained in:
parent
ea80e0d3f8
commit
5095e4f269
3 changed files with 29 additions and 12 deletions
|
|
@ -99,9 +99,14 @@ impl<T, S: GetSpan> WithSpan<T, S> for Result<T, ErrorKind> {
|
|||
error =
|
||||
Error::new(ErrorKind::BytecodeError(Box::new(error)), span.span());
|
||||
}
|
||||
Frame::Generator { span, .. } => {
|
||||
error =
|
||||
Error::new(ErrorKind::NativeError(Box::new(error)), span.span());
|
||||
Frame::Generator { name, span, .. } => {
|
||||
error = Error::new(
|
||||
ErrorKind::NativeError {
|
||||
err: Box::new(error),
|
||||
gen_type: name,
|
||||
},
|
||||
span.span(),
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue