maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore(tvix/eval): remove From<SmolStr> for NixString instance

Browse source 
No longer needed, and in some cases caused some extra work.

Change-Id: I64e8e7292573bdc92a9c7a8e470e33f8c526f311
Reviewed-on: https://cl.tvl.fyi/c/depot/+/8152
Reviewed-by: raitobezarius <tvl@lahfa.xyz>
Tested-by: BuildkiteCI
This commit is contained in:
Vincent Ambo 2023-02-27 13:44:06 +03:00 • committed by tazjin
parent 1941082cbb
commit 52b7a76268
3 changed files with 12 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tvix/eval/src/value/string.rs
View file

@ -4,7 +4,6 @@
//! level, allowing us to shave off some memory overhead and only
//! paying the cost when creating new strings.
use rnix::ast;
use smol_str::SmolStr;
use std::ffi::OsStr;
use std::hash::Hash;
use std::ops::Deref;
@ -50,9 +49,9 @@ impl From<String> for NixString {
}
}
impl From<SmolStr> for NixString {
fn from(s: SmolStr) -> Self {
NixString(Box::from(s.as_str()))
impl From<Box<str>> for NixString {
fn from(s: Box<str>) -> Self {
Self(s)
}
}