maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(tvix/eval): remove Box in new_suspended_native

Browse source 
This is unnecessary, Rc already provides all the boxing we need.

Change-Id: I08cf0939c48da43f04c847526c7e5dae5336d528
Reviewed-on: https://cl.tvl.fyi/c/depot/+/7749
Tested-by: BuildkiteCI
Reviewed-by: grfn <grfn@gws.fyi>
Reviewed-by: sterni <sternenseemann@systemli.org>
This commit is contained in:
Vincent Ambo 2023-01-04 17:21:09 +03:00 • committed by tazjin
parent b9646ab40c
commit 559a09c5e6
3 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tvix/eval/src/compiler/mod.rs
View file

@ -1288,7 +1288,7 @@ pub fn prepare_globals(
let weak_globals = weak.clone();
builtins_under_construction.insert(
"builtins",
Value::Thunk(Thunk::new_suspended_native(Rc::new(Box::new(move |_| {
Value::Thunk(Thunk::new_suspended_native(Rc::new(move |_| {
let file = source.add_file("builtins-dot-builtins.nix".into(), "builtins".into());
let span = file.span;
let mut observer = NoOpObserver::default();
@ -1305,7 +1305,7 @@ pub fn prepare_globals(
weak_globals.upgrade().unwrap().get("builtins").unwrap()(&mut compiler, span);
Ok(compiler.chunk().constants[0].clone())
})))),
}))),
);
// This is followed by the actual `builtins` attribute set