maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tvix/eval): emit warnings from builtins.import again

Browse source 
Wires up generator logic to emit warnings that already have spans
attached again.

Change-Id: I9f878cec3b9d4f6f7819e7c71bab7ae70bd3f08b
Reviewed-on: https://cl.tvl.fyi/c/depot/+/8224
Tested-by: BuildkiteCI
Reviewed-by: raitobezarius <tvl@lahfa.xyz>
This commit is contained in:
Vincent Ambo 2023-03-06 17:23:17 +03:00 • committed by tazjin
parent 43b0416bd8
commit 5d9bfd7735
3 changed files with 35 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tvix/eval/src/builtins/mod.rs
View file

@ -923,7 +923,8 @@ mod pure_builtins {
#[builtin("placeholder")]
async fn builtin_placeholder(co: GenCo, #[lazy] _x: Value) -> Result<Value, ErrorKind> {
generators::emit_warning(&co, WarningKind::NotImplemented("builtins.placeholder")).await;
generators::emit_warning_kind(&co, WarningKind::NotImplemented("builtins.placeholder"))
.await;
Ok("<builtins.placeholder-is-not-implemented-in-tvix-yet>".into())
}
@ -1017,7 +1018,7 @@ mod placeholder_builtins {
#[lazy] _context: Value,
#[lazy] val: Value,
) -> Result<Value, ErrorKind> {
generators::emit_warning(&co, WarningKind::NotImplemented("builtins.addErrorContext"))
generators::emit_warning_kind(&co, WarningKind::NotImplemented("builtins.addErrorContext"))
.await;
Ok(val)
}
@ -1028,7 +1029,7 @@ mod placeholder_builtins {
_name: Value,
_attrset: Value,
) -> Result<Value, ErrorKind> {
generators::emit_warning(
generators::emit_warning_kind(
&co,
WarningKind::NotImplemented("builtins.unsafeGetAttrsPos"),
)