maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tvix/eval): emit warnings from builtins.import again

Browse source 
Wires up generator logic to emit warnings that already have spans
attached again.

Change-Id: I9f878cec3b9d4f6f7819e7c71bab7ae70bd3f08b
Reviewed-on: https://cl.tvl.fyi/c/depot/+/8224
Tested-by: BuildkiteCI
Reviewed-by: raitobezarius <tvl@lahfa.xyz>
This commit is contained in:
Vincent Ambo 2023-03-06 17:23:17 +03:00 • committed by tazjin
parent 43b0416bd8
commit 5d9bfd7735
3 changed files with 35 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tvix/eval/src/compiler/import.rs
View file

@ -77,10 +77,9 @@ async fn import_impl(
});
}
// TODO: emit not just the warning kind, hmm
// for warning in result.warnings {
// vm.push_warning(warning);
// }
for warning in result.warnings {
generators::emit_warning(&co, warning).await;
}
// Compilation succeeded, we can construct a thunk from whatever it spat
// out and return that.