maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(tvix/eval): Drop LightSpan entirely

Browse source 
This was made unnecessary in c92d06271 (feat(tvix/eval): drop
LightSpan::Delayed, 2023-12-08) because it didn't improve benchmarks as
much as expected and has been vestigial since; this continues the
cleanup by just removing it altogether

Change-Id: I21ec7ae9b52a5cccd2092696a5a87f658194d672
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11949
Autosubmit: aspen <root@gws.fyi>
Tested-by: BuildkiteCI
Reviewed-by: flokli <flokli@flokli.de>
This commit is contained in:
Aspen Smith 2024-07-04 13:42:50 -04:00 • committed by clbot
parent 8e31088a01
commit 6037888e18
8 changed files with 109 additions and 175 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tvix/eval/src/builtins/mod.rs
View file

@ -525,11 +525,7 @@ mod pure_builtins {
let span = generators::request_span(&co).await;
for i in 0..len {
let val = Value::Thunk(Thunk::new_suspended_call(
generator.clone(),
i.into(),
span.clone(),
));
let val = Value::Thunk(Thunk::new_suspended_call(generator.clone(), i.into(), span));
out.push_back(val);
}
@ -983,7 +979,7 @@ mod pure_builtins {
let span = generators::request_span(&co).await;
for val in list.to_list()? {
let result = Value::Thunk(Thunk::new_suspended_call(f.clone(), val, span.clone()));
let result = Value::Thunk(Thunk::new_suspended_call(f.clone(), val, span));
out.push_back(result)
}
@ -1006,9 +1002,9 @@ mod pure_builtins {
let result = Value::Thunk(Thunk::new_suspended_call(
f.clone(),
key.clone().into(),
span.clone(),
span,
));
let result = Value::Thunk(Thunk::new_suspended_call(result, value, span.clone()));
let result = Value::Thunk(Thunk::new_suspended_call(result, value, span));
out.insert(key, result);
}