maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(3p/nix): Apply clang-tidy's readability-* fixes

Browse source 
This applies the readability fixes listed here:

https://clang.llvm.org/extra/clang-tidy/checks/list.html
This commit is contained in:
Vincent Ambo 2020-05-20 22:27:37 +01:00
parent d331d3a0b5
commit 689ef502f5
78 changed files with 863 additions and 792 deletions
Download patch file Download diff file Expand all files Collapse all files

6
third_party/nix/src/nix-instantiate/nix-instantiate.cc vendored
View file

@ -63,13 +63,13 @@ void processExpr(EvalState& state, const Strings& attrPaths, bool parseOnly,
/* What output do we want? */
string outputName = i.queryOutputName();
if (outputName == "") {
if (outputName.empty()) {
throw Error(
format("derivation '%1%' lacks an 'outputName' attribute ") %
drvPath);
}
if (gcRoot == "") {
if (gcRoot.empty()) {
printGCWarning();
} else {
Path rootName = indirectRoot ? absPath(gcRoot) : gcRoot;
@ -173,7 +173,7 @@ static int _main(int argc, char** argv) {
if (findFile) {
for (auto& i : files) {
Path p = state->findFile(i);
if (p == "") {
if (p.empty()) {
throw Error(format("unable to find '%1%'") % i);
}
std::cout << p << std::endl;