refactor(tvix/store): use bytes for node names and symlink targets

Some paths might use names that are not valid UTF-8. We should be able
to represent them.

We don't actually need to touch the PathInfo structures, as they need to
represent StorePaths, which come with their own harder restrictions,
which can't encode non-UTF8 data.

While this doesn't change any of the wire format of the gRPC messages,
it does however change the interface of tvix_eval::EvalIO - its
read_dir() method does now return a list of Vec<u8>, rather than
SmolStr. Maybe this should be OsString instead?

Change-Id: I821016d9a58ec441ee081b0b9f01c9240723af0b
Reviewed-on: https://cl.tvl.fyi/c/depot/+/8974
Autosubmit: flokli <flokli@flokli.de>
Reviewed-by: raitobezarius <tvl@lahfa.xyz>
Tested-by: BuildkiteCI
This commit is contained in:
Florian Klink 2023-07-18 19:37:25 +03:00 committed by clbot
parent 638f3e874d
commit 72e82ffcb1
27 changed files with 245 additions and 253 deletions

View file

@ -25,7 +25,7 @@ message Directory {
// A DirectoryNode represents a directory in a Directory.
message DirectoryNode {
// The (base)name of the directory
string name = 1;
bytes name = 1;
// The blake3 hash of a Directory message, serialized in protobuf canonical form.
bytes digest = 2;
// Number of child elements in the Directory referred to by `digest`.
@ -44,7 +44,7 @@ message DirectoryNode {
// A FileNode represents a regular or executable file in a Directory.
message FileNode {
// The (base)name of the file
string name = 1;
bytes name = 1;
// The blake3 digest of the file contents
bytes digest = 2;
// The file content size
@ -56,7 +56,7 @@ message FileNode {
// A SymlinkNode represents a symbolic link in a Directory.
message SymlinkNode {
// The (base)name of the symlink
string name = 1;
bytes name = 1;
// The target of the symlink.
string target = 2;
bytes target = 2;
}