From 7ba2cd9f52fcff1188bc8e91c7dcb5b72f3056ef Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Fri, 21 Mar 2025 01:58:48 +0000 Subject: [PATCH] fix(snix/eval/value): drop into_bstring We have a `impl From for BString` already. Change-Id: I278b62ac06ffaf47b2b0ecf394f0bc67213b5c40 Reviewed-on: https://cl.snix.dev/c/snix/+/30226 Autosubmit: Florian Klink Tested-by: besadii Reviewed-by: Ryan Lahfa --- snix/eval/src/value/string/mod.rs | 4 ---- snix/eval/src/vm/mod.rs | 7 +------ 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/snix/eval/src/value/string/mod.rs b/snix/eval/src/value/string/mod.rs index 003b2bf2e..efc461ece 100644 --- a/snix/eval/src/value/string/mod.rs +++ b/snix/eval/src/value/string/mod.rs @@ -638,10 +638,6 @@ impl NixString { std::str::from_utf8(self.as_bytes()) } - pub fn into_bstring(self) -> BString { - self.as_bstr().to_owned() - } - /// Return a displayable representation of the string as an /// identifier. /// diff --git a/snix/eval/src/vm/mod.rs b/snix/eval/src/vm/mod.rs index 78272f001..babe95f7b 100644 --- a/snix/eval/src/vm/mod.rs +++ b/snix/eval/src/vm/mod.rs @@ -801,12 +801,7 @@ where .unwrap_or(0); self.enqueue_generator("resolve_with", op_span, |co| { - resolve_with( - co, - ident.as_bstr().to_owned(), - with_stack_len, - closed_with_stack_len, - ) + resolve_with(co, ident.into(), with_stack_len, closed_with_stack_len) }); return Ok(false);