feat(tvix/eval): Box Value::Catchable
This is now the only enum variant for Value that is larger than 8 bytes (it's 16 bytes), so boxing it (especially since it's not perf-critical) allows us to get the Value size down to only 16 bytes! Change-Id: I98598e2b762944448bef982e8ff7da6d6683c4aa Reviewed-on: https://cl.tvl.fyi/c/depot/+/10798 Tested-by: BuildkiteCI Reviewed-by: raitobezarius <tvl@lahfa.xyz> Autosubmit: aspen <root@gws.fyi>
This commit is contained in:
parent
dd26177319
commit
7e286aab1a
11 changed files with 45 additions and 40 deletions
|
|
@ -27,7 +27,7 @@ async fn import_impl(
|
|||
) -> Result<Value, ErrorKind> {
|
||||
// TODO(sterni): canon_path()?
|
||||
let mut path = match coerce_value_to_path(&co, args.pop().unwrap()).await? {
|
||||
Err(cek) => return Ok(Value::Catchable(cek)),
|
||||
Err(cek) => return Ok(Value::Catchable(Box::new(cek))),
|
||||
Ok(path) => path,
|
||||
};
|
||||
|
||||
|
|
|
|||
|
|
@ -399,9 +399,9 @@ impl Compiler<'_> {
|
|||
// TODO: decide what to do with findFile
|
||||
if raw_path.len() == 2 {
|
||||
return self.emit_constant(
|
||||
Value::Catchable(CatchableErrorKind::NixPathResolution(
|
||||
Value::Catchable(Box::new(CatchableErrorKind::NixPathResolution(
|
||||
"Empty <> path not allowed".into(),
|
||||
)),
|
||||
))),
|
||||
node,
|
||||
);
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue