maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

docs(tvix/castore/blobservice): explain open_read for small blobs more

Browse source 
State that this case applies if the blob is small enough to fit inside a
single chunk.

Change-Id: I0383514729e686799599b629cf1303b284147bb4
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11440
Autosubmit: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
Reviewed-by: Connor Brewster <cbrewster@hey.com>
This commit is contained in:
Florian Klink 2024-04-14 17:06:43 +03:00 • committed by clbot
parent e958cb0251
commit 80d0b305a7
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
tvix/castore/src/blobservice/object_store.rs
View file

@ -149,6 +149,7 @@ impl BlobService for ObjectStoreBlobService {
.await .await
{ {
Ok(res) => { Ok(res) => {
// handle reading blobs that are small enough to fit inside a single chunk:
// fetch the entire chunk into memory, decompress, ensure the b3 digest matches, // fetch the entire chunk into memory, decompress, ensure the b3 digest matches,
// and return a io::Cursor over that data. // and return a io::Cursor over that data.
// FUTUREWORK: use zstd::bulk to prevent decompression bombs // FUTUREWORK: use zstd::bulk to prevent decompression bombs