From 8342f70c60a2045e4422d77a06baa187d7ff6c28 Mon Sep 17 00:00:00 2001
From: Yureka <tvl@yuka.dev>
Date: Mon, 22 Jul 2024 13:14:21 +0200
Subject: [PATCH] feat(tvix/composition): improve error message for unknown tag

Change-Id: I61a31488de17725ae4311f5f5bf8e02edb752cf9
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12017
Reviewed-by: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
---
 tvix/castore/src/composition.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tvix/castore/src/composition.rs b/tvix/castore/src/composition.rs
index 3550695a8..c76daafc5 100644
--- a/tvix/castore/src/composition.rs
+++ b/tvix/castore/src/composition.rs
@@ -149,7 +149,7 @@ impl<'r, 'de: 'r, T: 'static> SeedFactory<'de, TagString<'de>> for RegistryWithF
              .0
             .iter()
             .find(|(k, _)| *k == &(TypeId::of::<T>(), tag.as_ref()))
-            .ok_or_else(|| serde::de::Error::custom("Unknown tag"))?
+            .ok_or_else(|| serde::de::Error::custom(format!("Unknown type: {}", tag)))?
             .1;
 
         let entry: &RegistryEntry<T> = <dyn Any>::downcast_ref(&**seed).unwrap();
@@ -215,7 +215,7 @@ impl<'de, T: 'static> serde::Deserialize<'de> for DeserializeWithRegistry<T> {
 
 #[derive(Debug, thiserror::Error)]
 enum TryFromUrlError {
-    #[error("Unknown tag: {0}")]
+    #[error("Unknown type: {0}")]
     UnknownTag(String),
 }