maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

style(3p/nix): Remove 'using std::*' from types.hh

Browse source 
It is considered bad form to use things from includes in headers, as
these directives propagate to everywhere else and can make it
confusing.

types.hh (which is includes almost literally everywhere) had some of
these directives, which this commit removes.
This commit is contained in:
Vincent Ambo 2020-05-24 22:29:21 +01:00
parent f30b2e610d
commit 838f86b0fd
85 changed files with 859 additions and 821 deletions
Download patch file Download diff file Expand all files Collapse all files

12
third_party/nix/src/libutil/serialise.hh vendored
View file

@ -135,9 +135,9 @@ struct StringSink : Sink {
/* A source that reads data from a string. */
struct StringSource : Source {
const string& s;
const std::string& s;
size_t pos;
StringSource(const string& _s) : s(_s), pos(0) {}
StringSource(const std::string& _s) : s(_s), pos(0) {}
size_t read(unsigned char* data, size_t len) override;
};
@ -231,7 +231,7 @@ inline Sink& operator<<(Sink& sink, uint64_t n) {
return sink;
}
Sink& operator<<(Sink& sink, const string& s);
Sink& operator<<(Sink& sink, const std::string& s);
Sink& operator<<(Sink& sink, const Strings& s);
Sink& operator<<(Sink& sink, const StringSet& s);
@ -265,12 +265,12 @@ inline uint64_t readLongLong(Source& source) {
void readPadding(size_t len, Source& source);
size_t readString(unsigned char* buf, size_t max, Source& source);
string readString(Source& source,
size_t max = std::numeric_limits<size_t>::max());
std::string readString(Source& source,
size_t max = std::numeric_limits<size_t>::max());
template <class T>
T readStrings(Source& source);
Source& operator>>(Source& in, string& s);
Source& operator>>(Source& in, std::string& s);
template <typename T>
Source& operator>>(Source& in, T& n) {