refactor(tvix/eval): remove extra Rc<..> around Value::Attrs
The `im::OrdMap` is already small and cheap to copy while sharing memory, so this is not required anymore. Only the `KV` variant may have slightly larger content, but in practice this doesn't seem to make a difference when comparing the two variants and this one is less complicated. Change-Id: I64a563b209a2444125653777551373cb2989ca7d Reviewed-on: https://cl.tvl.fyi/c/depot/+/7677 Reviewed-by: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
This commit is contained in:
parent
91465dc78e
commit
86361f0f4a
5 changed files with 24 additions and 21 deletions
|
|
@ -173,6 +173,17 @@ impl NixAttrs {
|
|||
Self(AttrsRep::Empty)
|
||||
}
|
||||
|
||||
/// Compare two attribute sets by pointer equality. Only makes
|
||||
/// sense for some attribute set reprsentations, i.e. returning
|
||||
/// `false` does not mean that the two attribute sets do not have
|
||||
/// equal *content*.
|
||||
pub fn ptr_eq(&self, other: &Self) -> bool {
|
||||
match (&self.0, &other.0) {
|
||||
(AttrsRep::Im(lhs), AttrsRep::Im(rhs)) => lhs.ptr_eq(rhs),
|
||||
_ => false,
|
||||
}
|
||||
}
|
||||
|
||||
/// Return an attribute set containing the merge of the two
|
||||
/// provided sets. Keys from the `other` set have precedence.
|
||||
pub fn update(self, other: Self) -> Self {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue