maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(tvix/glue): tune instrumentations in TvixStoreIO

Browse source 
Print store paths with their ToString implementation for brevity, and
don't log the sucessful return value of read_to_string.

Change-Id: I01b6838398acd66b8818095622f361fcca26fa77
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10854
Autosubmit: flokli <flokli@flokli.de>
Reviewed-by: raitobezarius <tvl@lahfa.xyz>
Tested-by: BuildkiteCI
This commit is contained in:
Florian Klink 2024-02-14 08:58:10 +07:00 • committed by flokli
parent 44624284fd
commit 87bda3ae7a
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tvix/glue/src/tvix_store_io.rs
View file

@ -74,7 +74,7 @@ impl TvixStoreIO {
/// ///
/// In case there is no PathInfo yet, this means we need to build it /// In case there is no PathInfo yet, this means we need to build it
/// (which currently is stubbed out still). /// (which currently is stubbed out still).
#[instrument(skip(self), ret, err)] #[instrument(skip(self, store_path), fields(store_path=%store_path), ret, err)]
async fn store_path_to_node( async fn store_path_to_node(
&self, &self,
store_path: &StorePath, store_path: &StorePath,
@ -138,7 +138,7 @@ impl EvalIO for TvixStoreIO {
} }
} }
#[instrument(skip(self), ret, err)] #[instrument(skip(self), err)]
fn read_to_string(&self, path: &Path) -> io::Result<String> { fn read_to_string(&self, path: &Path) -> io::Result<String> {
if let Ok((store_path, sub_path)) = if let Ok((store_path, sub_path)) =
StorePath::from_absolute_path_full(&path.to_string_lossy()) StorePath::from_absolute_path_full(&path.to_string_lossy())