maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(3p/nix): Make all single-argument constructors explicit

Browse source 
Implicit constructors can be confusing, especially in a codebase that
is already as unintentionally obfuscated as this one.

https://google.github.io/styleguide/cppguide.html#Explicit_Constructors
This commit is contained in:
Vincent Ambo 2020-05-19 22:02:23 +01:00
parent 3908732181
commit 88f337588c
12 changed files with 31 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

12
third_party/nix/src/libutil/compression.cc vendored
View file

@ -34,7 +34,7 @@ struct ChunkedCompressionSink : CompressionSink {
struct NoneSink : CompressionSink {
Sink& nextSink;
NoneSink(Sink& nextSink) : nextSink(nextSink) {}
explicit NoneSink(Sink& nextSink) : nextSink(nextSink) {}
void finish() override { flush(); }
void write(const unsigned char* data, size_t len) override {
nextSink(data, len);
@ -47,7 +47,7 @@ struct XzDecompressionSink : CompressionSink {
lzma_stream strm = LZMA_STREAM_INIT;
bool finished = false;
XzDecompressionSink(Sink& nextSink) : nextSink(nextSink) {
explicit XzDecompressionSink(Sink& nextSink) : nextSink(nextSink) {
lzma_ret ret = lzma_stream_decoder(&strm, UINT64_MAX, LZMA_CONCATENATED);
if (ret != LZMA_OK) {
throw CompressionError("unable to initialise lzma decoder");
@ -92,7 +92,7 @@ struct BzipDecompressionSink : ChunkedCompressionSink {
bz_stream strm;
bool finished = false;
BzipDecompressionSink(Sink& nextSink) : nextSink(nextSink) {
explicit BzipDecompressionSink(Sink& nextSink) : nextSink(nextSink) {
memset(&strm, 0, sizeof(strm));
int ret = BZ2_bzDecompressInit(&strm, 0, 0);
if (ret != BZ_OK) {
@ -140,7 +140,7 @@ struct BrotliDecompressionSink : ChunkedCompressionSink {
BrotliDecoderState* state;
bool finished = false;
BrotliDecompressionSink(Sink& nextSink) : nextSink(nextSink) {
explicit BrotliDecompressionSink(Sink& nextSink) : nextSink(nextSink) {
state = BrotliDecoderCreateInstance(nullptr, nullptr, nullptr);
if (!state) {
throw CompressionError("unable to initialize brotli decoder");
@ -284,7 +284,7 @@ struct BzipCompressionSink : ChunkedCompressionSink {
bz_stream strm;
bool finished = false;
BzipCompressionSink(Sink& nextSink) : nextSink(nextSink) {
explicit BzipCompressionSink(Sink& nextSink) : nextSink(nextSink) {
memset(&strm, 0, sizeof(strm));
int ret = BZ2_bzCompressInit(&strm, 9, 0, 30);
if (ret != BZ_OK) {
@ -333,7 +333,7 @@ struct BrotliCompressionSink : ChunkedCompressionSink {
BrotliEncoderState* state;
bool finished = false;
BrotliCompressionSink(Sink& nextSink) : nextSink(nextSink) {
explicit BrotliCompressionSink(Sink& nextSink) : nextSink(nextSink) {
state = BrotliEncoderCreateInstance(nullptr, nullptr, nullptr);
if (!state) {
throw CompressionError("unable to initialise brotli encoder");