feat(achilles): Implement a Unit type

Add support for a zero-sized Unit type. This requires some special at
the codegen level because LLVM (unsurprisingly) only allows Void types
in function return position - to make that a little easier to handle
there's a new pass that strips any unit-only expressions and pulls
unit-only function arguments up to new `let` bindings, so we never have
to actually pass around unit values.

Change-Id: I0fc18a516821f2d69172c42a6a5d246b23471e38
Reviewed-on: https://cl.tvl.fyi/c/depot/+/2695
Reviewed-by: glittershark <grfn@gws.fyi>
Tested-by: BuildkiteCI
This commit is contained in:
Griffin Smith 2021-03-28 13:28:49 -04:00 committed by glittershark
parent db62866d82
commit 8e13b1303a
16 changed files with 447 additions and 88 deletions

View file

@ -186,7 +186,9 @@ named!(string(&str) -> Literal, preceded!(
)
));
named!(literal(&str) -> Literal, alt!(int | bool_ | string));
named!(unit(&str) -> Literal, map!(complete!(tag!("()")), |_| Literal::Unit));
named!(literal(&str) -> Literal, alt!(int | bool_ | string | unit));
named!(literal_expr(&str) -> Expr, map!(literal, Expr::Literal));
@ -270,7 +272,6 @@ named!(funcref(&str) -> Expr, alt!(
named!(no_arg_call(&str) -> Expr, do_parse!(
fun: funcref
>> multispace0
>> complete!(tag!("()"))
>> (Expr::Call {
fun: Box::new(fun),
@ -431,6 +432,11 @@ pub(crate) mod tests {
}
}
#[test]
fn unit() {
assert_eq!(test_parse!(expr, "()"), Expr::Literal(Literal::Unit));
}
#[test]
fn bools() {
assert_eq!(
@ -515,6 +521,18 @@ pub(crate) mod tests {
);
}
#[test]
fn unit_call() {
let res = test_parse!(expr, "f ()");
assert_eq!(
res,
Expr::Call {
fun: ident_expr("f"),
args: vec![Expr::Literal(Literal::Unit)]
}
)
}
#[test]
fn call_with_args() {
let res = test_parse!(expr, "f x 1");