maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve exwm-workspace-move-window behavior in specific case

Browse source 
This is a small change that improves the behavior of
`exwm-workspace-move-window` in the following situation:

0. `exwm-workspace-show-all-buffers` and `exwm-layout-show-all-buffers`
are `nil`*.
1. On active workspace `i`, there is X window `a` in the selected Emacs
window.
2. On workspace `j`, there is X window `b` in the selected Emacs window
on that workspace frame.
3. While workspace `i` is active, use `exwm-workspace-move-window` to
move `a` to workspace `j`.
4. Switch to workspace `j` and use `exwm-workspace-move-window` to move
`a` back to workspace `i`.

Expected behavior: X window `a` is once again shown in the selected
Emacs window on workspace `i` and X window `b` is once again shown in
the selected Emacs window on workspace `j`.

What is observed: `a` is OK but the selected Emacs window on workspace
`j` does not show `b`. However, `b` is the first candidate when doing a
`switch-to-buffer` in that Emacs window on workspace `j`.

I'm not sure if this is the correct and complete change required, but it
is working well so far.

*The expected behavior is observed with EXWM 0.10 if
exwm-{workspace,layout}-show-all-buffers are non-nil.
This commit is contained in:
Ved Vyas 2016-08-30 12:10:45 -04:00
parent cfcaed691b
commit 9105f23121
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
exwm-workspace.el
View file

@ -746,10 +746,9 @@ INDEX must not exceed the current number of workspaces."
(frame-root-window (frame-root-window
exwm--floating-frame))))) exwm--floating-frame)))))
;; Move the X window container. ;; Move the X window container.
(if (eq frame exwm-workspace--current)
(set-window-buffer (get-buffer-window (current-buffer) t) (set-window-buffer (get-buffer-window (current-buffer) t)
(other-buffer)) (other-buffer))
(bury-buffer) (unless (eq frame exwm-workspace--current)
;; Clear the 'exwm-selected-window' frame parameter. ;; Clear the 'exwm-selected-window' frame parameter.
(set-frame-parameter frame 'exwm-selected-window nil)) (set-frame-parameter frame 'exwm-selected-window nil))
(exwm-layout--hide id) (exwm-layout--hide id)