feat(storage): Store blob content-type in extended attributes

After the discussion in #116, this stores the blob content types
in extended attributes when using the filesystem backend.

If the underlying filesystem doesn't support extended attributes,
storing blobs won't work; also, if extended attributes get removed,
blobs won't be served anymore. We can relax this behavior if
needed (i.e. log errors but still accept to store or serve blobs).
However, since the Docker Engine (and possibly other container
engines) won't accept to pull images from a registry that doesn't
use correct content types for manifest files, it could be argued
that it's better to give a hard fail. (Otherwise, the container
engine gives cryptic error messages like "missing signature key".)

I can change that behavior (and log errors but still store/serve
blobs to the filesystem) if you think it's better.
This commit is contained in:
Jérôme Petazzoni 2021-04-22 16:52:12 +02:00 committed by Vincent Ambo
parent 3efbbfcd4e
commit 94e04a76b6
4 changed files with 20 additions and 3 deletions

View file

@ -38,7 +38,7 @@ let
doCheck = true;
# Needs to be updated after every modification of go.mod/go.sum
vendorSha256 = "1ff0kfww6fy6pnvyva7x8cc6l1d12aafps48wrkwawk2qjy9a8b9";
vendorSha256 = "1adjav0dxb97ws0w2k50rhk6r46wvfry6aj4sik3ninl525kd15s";
buildFlagsArray = [
"-ldflags=-s -w -X main.version=${nixery-commit-hash}"