maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore(tvix): drop sled compression support

Browse source 
It's been a while since the last sled release, and that one binds to a
pretty old version of zstd, requiring workarounds like cl/10090.

Upstream sled main branch currently has zstd halfway patched out (it's
a no-op, but the feature flag and options are still there), and it's in
that state for a year.

Rather than maintaining our own fork of sled, let's just stop using the
compression feature in sled, dropping the version pin to zstd that way,
removing the need for cl/10090.

This doesn't mean we won't reintroduce per-blob compression - but we
probably just won't let sled take care of the compression, but do it
ourselves - which is necessary for more chunked blob storage anyways.

Even though we do drop the feature flag, we still need to explicitly use
use_compression(false).

Change-Id: I0e4892d29e41c76653272dc1a3625180da6fee12
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10257
Autosubmit: flokli <flokli@flokli.de>
Reviewed-by: raitobezarius <tvl@lahfa.xyz>
Tested-by: BuildkiteCI
This commit is contained in:
Florian Klink 2023-12-11 21:25:34 +02:00 • committed by clbot
parent 6025be423a
commit 9748543f1c
9 changed files with 14 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tvix/Cargo.nix
View file

@ -7426,11 +7426,6 @@ rec {
name = "parking_lot";
packageId = "parking_lot 0.11.2";
}
{
name = "zstd";
packageId = "zstd";
optional = true;
}
];
devDependencies = [
{
@ -7450,7 +7445,7 @@ rec {
"testing" = [ "event_log" "lock_free_delays" "compression" "failpoints" "backtrace" ];
"zstd" = [ "dep:zstd" ];
};
resolvedDefaultFeatures = [ "compression" "default" "no_metrics" "zstd" ];
resolvedDefaultFeatures = [ "default" "no_metrics" ];
};
"smallvec" = rec {
crateName = "smallvec";
@ -9457,7 +9452,6 @@ rec {
{
name = "sled";
packageId = "sled";
features = [ "compression" ];
}
{
name = "thiserror";
@ -9980,7 +9974,6 @@ rec {
{
name = "sled";
packageId = "sled";
features = [ "compression" ];
}
{
name = "thiserror";