From 98df0e4e34683db103d1b258ed7449676f647dae Mon Sep 17 00:00:00 2001
From: Florian Klink <flokli@flokli.de>
Date: Fri, 18 Oct 2024 13:48:50 +0200
Subject: [PATCH] fix(tvix/store/grpc_wrapper): don't validate node name

Clients can (and do) send an empty name in here, and we discard it
anyways.

Change-Id: Iec135d9cba48cc066464e5639319c845079787e9
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12659
Reviewed-by: edef <edef@edef.eu>
Tested-by: BuildkiteCI
Autosubmit: flokli <flokli@flokli.de>
---
 tvix/store/src/proto/grpc_pathinfoservice_wrapper.rs | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/tvix/store/src/proto/grpc_pathinfoservice_wrapper.rs b/tvix/store/src/proto/grpc_pathinfoservice_wrapper.rs
index 5da3b23c2..d003d4bdb 100644
--- a/tvix/store/src/proto/grpc_pathinfoservice_wrapper.rs
+++ b/tvix/store/src/proto/grpc_pathinfoservice_wrapper.rs
@@ -77,10 +77,13 @@ where
         &self,
         request: Request<castorepb::Node>,
     ) -> Result<Response<proto::CalculateNarResponse>> {
-        let (_, root_node) = request.into_inner().into_name_and_node().map_err(|e| {
-            warn!(err = %e, "invalid root node");
-            Status::invalid_argument("invalid root node")
-        })?;
+        let (_, root_node) = request
+            .into_inner()
+            .into_name_bytes_and_node()
+            .map_err(|e| {
+                warn!(err = %e, "invalid root node");
+                Status::invalid_argument("invalid root node")
+            })?;
 
         match self.nar_calculation_service.calculate_nar(&root_node).await {
             Ok((nar_size, nar_sha256)) => Ok(Response::new(proto::CalculateNarResponse {