From 9bbfbd7df38908f64bdf8d4487cb06b13011db17 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Mon, 5 May 2025 18:03:46 +0300 Subject: [PATCH] docs(snix/docs/TODO): drop Error cleanup TODO Migrated to #134. Change-Id: I555219085fea8c192e769cb7b5357321087ffdf7 Reviewed-on: https://cl.snix.dev/c/snix/+/30479 Autosubmit: Florian Klink Reviewed-by: Jonas Chevalier Tested-by: besadii --- snix/docs/src/TODO.md | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/snix/docs/src/TODO.md b/snix/docs/src/TODO.md index ea396918f..edc8b586d 100644 --- a/snix/docs/src/TODO.md +++ b/snix/docs/src/TODO.md @@ -35,21 +35,6 @@ the resulting diff noise on resulting mismtaches). in resulting store paths. -## Error cleanup - - Currently, all services use snix_castore::Error, which only has two kinds - (invalid request, storage error), containing an (owned) string. - This is quite primitive. We should have individual error types for BS, DS, PS. - Maybe these should have some generics to still be able to carry errors from - the underlying backend, similar to `IngestionError`. - There was an attempt to give PS separate error types (cl/11695), but this - ended up very verbose. - Every error had to be boxed, and a possible additional message be added. Some - errors that didn't wrap another underlying errors were hard to construct, too - (requiring the addition of errors). All of this without even having added - proper backtrace support, which would be quite helpful in store hierarchies. - `anyhow`'s `.context()` gives us most of this out of the box. Maybe we can - use that, using enums rather than `&'static str` as context in some cases? - ## Documentation Extend the other pages in here. Some ideas on what should be tackled: - Document what Tvix is, and what it is not yet. What it is now, what it is not