feat(nix-compat/narinfo/signature): generalize name field
Requiring `name` to be a `&str` means it'll get annoying to pass around `Signature`, but being able to pass them around in an owned fashion is kinda a requirement for a stronger typed `PathInfo` struct, where we want to have full ownership. Rework the `Signature` struct to become generic over the type of the `name` field. This means, it becomes possible to have owned versions of it. We don't want to impose `String` or `SmolStr` for example, but want to leave it up to the nix-compat user to decide. Provide a type alias for the existing `&str` variant (`SignatureRef`), and use it where we previously used the non-generic `Signature` one. Add some tests to ensure it's possible to *use* `Signature` with both `String` and `SmolStr` (but only pull in `smol_str` as dev dependency for the tests). Also, add some more docstrings, these were a bit sparse. Change-Id: I3f75691498c6bda9cd072d2d9dac83c4f6c57287 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12253 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: raitobezarius <tvl@lahfa.xyz>
This commit is contained in:
parent
7612cb4c31
commit
a259613c76
9 changed files with 117 additions and 45 deletions
|
|
@ -221,7 +221,7 @@ impl PathInfo {
|
|||
.signatures
|
||||
.iter()
|
||||
.map(|sig| {
|
||||
nix_compat::narinfo::Signature::new(
|
||||
nix_compat::narinfo::SignatureRef::new(
|
||||
&sig.name,
|
||||
// This shouldn't pass validation
|
||||
sig.data[..].try_into().expect("invalid signature len"),
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue